CMS-46358 Add property group support #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t property groups
… and remove unused functions
exacs
reviewed
Oct 30, 2025
Contributor
exacs
left a comment
exacs
left a comment
There was a problem hiding this comment.
It looks good overall, but I have concerns with typing
| required?: boolean; | ||
| localized?: boolean; | ||
| group?: string; | ||
| group?: PropertyGroupKey; |
Contributor
There was a problem hiding this comment.
Does this mean that I have to declare the types (i.e. add to the PropertyGroupRegistry interface) for this to work?
What happens if I have define a property group in the CMS via UI?
Contributor
Author
There was a problem hiding this comment.
This change was introduced to allow built in types with string (I'll double check if strings are accepted). But If a developer defines a propertyGroup in CMS it wont show up as autocomplete or type-safe. If a developer use module augmentation using PropertyGroupRegistry interface it will show up as auto complete.
…y and refactor code.
|
|
JohanPetersson
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propertyGroupsin config file.propertyGroupsin CLI.propertyGroups.Note: type-safety is not implemented in this PR due to the lack of typescript support and
.mjsin config file which limits us on using module augmentation. More info can be found in CMS-46487