Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #253 by adding an
incubation_periodargument to thesim_linelist()andsim_outbreak()functions. These functions now allow the date/time of symptom onset to be some delay after the infection time by supplying an incubation period distribution (can be a function or an<epiparameter>object like the other delay distribution arguments in {simulist}).This changes is backwards compatible as the default incubation period is set to 0, but could be considered a breaking change due to a new argument being added to the middle of the function signatures of
sim_linelist()andsim_outbreak(), so any users that are calling these functions with arguments specified by position may encounter issues..sim_internal()is updated to add theincubation_periodwhen defining the$date_onset..check_sim_input()is updated to check theincubation_periodargument, andas_function()is updated to convert theincubation_periodif it'sNULLor an<epiparameter>object.