ci: Add action to update smoke tests.#1975
Open
nilscb wants to merge 14 commits intoequinor:masterfrom
Open
Conversation
Collaborator
|
I don't understand the logic !? We want to be able to run the update on our local machine, to update the reference images. |
Collaborator
Author
|
Updating the smoke tests does not work on windows. We want a PR to be automatically created with updated tests (if necessary): One may then merge this PR with the original to have updated tests. |
hkfb
reviewed
Mar 20, 2024
hkfb
requested changes
Mar 20, 2024
hkfb
reviewed
Mar 21, 2024
hkfb
reviewed
Mar 21, 2024
hkfb
reviewed
Mar 21, 2024
.github/workflows/typescript.yml
Outdated
| - name: Create Pull Request | ||
| id: cpr | ||
| uses: peter-evans/create-pull-request@5a6b15373e5788c38d83296b674ad5abea28085c | ||
| if: github.event_name == 'push' && (github.ref != 'refs/heads/master' || contains(github.event.head_commit.message, '[deploy test]')) |
Collaborator
There was a problem hiding this comment.
Not entirely sure what to make of this, but it looks like the event_name triggered is pull_request and not push
##[debug]Evaluating condition for step: 'Create Pull Request'
##[debug]Evaluating: (success() && (github.event_name == 'push') && ((github.ref != 'refs/heads/master') || contains(github.event.head_commit.message, '[deploy test]')))
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating Equal:
##[debug]....Evaluating Index:
##[debug]......Evaluating github:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'event_name'
##[debug]....=> 'pull_request'
##[debug]....Evaluating String:
##[debug]....=> 'push'
##[debug]..=> false
##[debug]=> false
##[debug]Expanded: (true && ('pull_request' == 'push') && ((github['ref'] != 'refs/heads/master') || contains(github['event']['head_commit']['message'], '[deploy test]')))
…nts into AddGithubAction
This reverts commit b034942.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.