Update so that generate is called passing the record in#23
Open
phuibonhoa wants to merge 2 commits intoequivalent:masterfrom
Open
Update so that generate is called passing the record in#23phuibonhoa wants to merge 2 commits intoequivalent:masterfrom
phuibonhoa wants to merge 2 commits intoequivalent:masterfrom
Conversation
This is a breaking change on NumberRandom which previously took a positional argument for the randomizer. Passing the record allows for more dynamic generators to base some part of the uid off the record. Ex. you may have a record that stores information on different media types. You could have a generator that produced ids like: "AUDIO-1HA348" and "VIDEO-7FOA72".
Owner
|
Thank you for this @phuibonhoa . Several changes in this PR. I need to think about them and test them 🤔. I won't be able to address this PR in near future (I have some personal & professional circumstances I need to resolve) Please give me few weeks to look at your proposed changes. |
Author
Understood, thanks for the update, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change on NumberRandom which previously took a positional argument for the randomizer.
Passing the record allows for more dynamic generators to base some part of the uid off the record. Ex. you may have a record that stores information on different media types. You could have a generator that produced ids like: "AUDIO-1HA348" and "VIDEO-7FOA72".