Add handling of negative indices to getitem #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 98.49% 98.58% +0.08%
==========================================
Files 3 3
Lines 266 282 +16
==========================================
+ Hits 262 278 +16
Misses 4 4
Continue to review full report at Codecov.
|
| return self._arr[item] | ||
| item_arr = np.asarray(item) | ||
| if issubclass(item_arr.dtype.type, np.integer): | ||
| item_arr = (item_arr + self._left_index) % self._capacity |
There was a problem hiding this comment.
Why not just:
item_arr = ((item_arr % len(self)) + self._left_index) % self._capacityinstead of lines 167-170? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will handle cases of
ringbuf[-<n>], which were failing whenself._arris not full.This may address the needs of your Issue #5, but I suspect it will not handle accesses when the index selector is an array_like with negative items.