Corrected color inconsistencies#156
Open
cyberlytics wants to merge 1 commit intoericdrowell:masterfrom
Open
Conversation
Changed color code of Bucket Sort, Radix Sort, and Counting Sort from green to yellow, to be in sync with the bigocheatsheet.com color code specs for O(n)
Author
|
(Obviously this should also impact your beautiful poster variant.) Without this correction you have a serious inconsistency with the (correct) yellow codings of Timsort, Bubble Sort, Insertion Sort and Cubesort in their Best Case scenario. They actualy perform better than Bucket Sort, Radix Sort, and Counting Sort but currently have the worse color. I can understand that there was the intention to mark Bucket Sort, Radix Sort, and Counting Sort as the best algorithms? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed color code of Bucket Sort, Radix Sort, and Counting Sort from green to yellow, to be in sync with the bigocheatsheet.com color code specs for O(n)