Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(scanner): pass scan country through frontend scan/submit flow (#924) #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(scanner): pass scan country through frontend scan/submit flow (#924) #936
Changes from all commits
3f98c36deaa626File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recordScanViaGatewaynow takesscanCountry, but when the gateway is reachable the request is handled byhandleRecordScan, which still callsapi_record_scanwith onlyp_ean(supabase/functions/api-gateway/index.ts:383-386). That meansscan_countryis only written in thegateway_unreachablefallback branch, so normal gateway traffic silently loses country context and skews country-aware scan metrics.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new country fields are only guaranteed in the direct-RPC fallback branch here; in the normal gateway-success path,
handleSubmitProductforwards onlyp_ean,p_product_name,p_brand,p_category,p_photo_url, andp_notes(supabase/functions/api-gateway/index.ts:494-500). When the gateway is up,scan_countryandsuggested_countryare dropped, which leaves country-targeted submission data incomplete.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.