Skip to content

[#27] Provide option for configuration file location #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[#27] Provide option for configuration file location #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b7cb8
[#27] Provide option for configuration file location
alanz Feb 19, 2020
8ae1f35
Merge branch 'master' into 27-config-file-option
jfacorro Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ export async function activate(context: ExtensionContext) {
workspace.createFileSystemWatcher('**/rebar.config'),
workspace.createFileSystemWatcher('**/rebar.lock')
]
},
initializationOptions: {
erlang: {
config_path: workspace.getConfiguration('erlang_ls').get('config.path'),
Copy link
Contributor

@jfacorro jfacorro Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use camelCase for configPath this could be workspace.getConfiguration('erlang_ls').configPath, instead.

}
}
};

Expand Down
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
"description":
"Override the default path of the erlang_ls executable with a custom one."
},
"erlang_ls.config.path": {
Copy link
Contributor

@jfacorro jfacorro Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other names for the configuration values are using camelCase for the names, shouldn't we keep it that way for this configuration as well?

"type": "string",
"description": "Path to the erlang_ls.config file. This can either be absolute or relative to the project root",
"default": ""
},
"erlang_ls.logPath": {
"scope": "window",
"type": "string",
Expand All @@ -77,6 +82,7 @@
"default": "info",
"description": "Log level of LS server"
}

}
},
"languages": [
Expand Down