[snmp] add deterministic option when available for asn #10288
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 2 files 24 suites 49m 29s ⏱️ Results for commit 5141eb9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
joaohf
commented
Oct 16, 2025
| $(SNMP_FLAGS) | ||
|
|
||
| ifeq ($(ERL_DETERMINISTIC),yes) | ||
| ASN1_OPTS += +deterministic |
Contributor
Author
There was a problem hiding this comment.
This ASN1_OPTS is used by lib/snmp/src/misc/depend.mk
Contributor
|
Hi, could you rebase your PR so that Create SBOM not longer fails? Its fixed on upstream |
joaohf
force-pushed
the
snmp-misc-asn-determinisc-build
branch
from
a28f1e6 to
1fbfa80
Compare
Contributor
Author
|
Hi @Whaileee I've just rebased it. Thanks |
Whaileee
added
testing
Avoid build paths for snmp_pdus_basic.beam when deterministic is enabled.
Whaileee
force-pushed
the
snmp-misc-asn-determinisc-build
branch
from
1fbfa80 to
5141eb9
Compare
Whaileee
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid build paths for snmp_pdus_basic.beam when deterministic is enabled.