feat: "atomic" get_handler_configs #10308
Open
+39
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkoMin
changed the title
CT Test Results 2 files 72 suites 1h 6m 34s ⏱️ Results for commit 27042fa. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
MarkoMin
force-pushed
the
fix/logger/get_handler_config
branch
from
b05969e to
e9e342f
Compare
jhogberg
added
the
testing
jhogberg
approved these changes
Nov 3, 2025
|
Thanks for the PR! Can you rebase this on top of the latest |
MarkoMin
force-pushed
the
fix/logger/get_handler_config
branch
from
52e0df2 to
27042fa
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the root issue is eliminated by matching on a ETS table instead of looking up repeatedly.
Testcase is a bit shady, but hope its good enough (any tips are more than welcome).
Closes #9997
P.S. Something to note before review: in the issue, @jhogberg mentioned that previous behavior might not be unexpected, but I can't think of a reason where one would want this to fail.