fixed setup.py (missing nettcp.stream) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
sry for the duplicate... I just saw that someone else submitted the same pull request, but closed it afterwards (#1) |
|
This PR saved lots of time for me, thanks! The project needs more love... |
Contributor
|
@v-p-b Feel free to maintain a fork. I'm not part of the org since 2017 anymore and don't know who has still permissions on this repository. Also not working with that stuff anymore, so I can't reasonably support it. |
|
Thanks for the heads up and the work you've put in so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thx for this! Unfortunately, your setup.py was missing 'nettcp.stream', thus breaking the install. This trivial change should fix it.