Add node-fetch and cross-fetch #272
Open
+130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
Dec 26, 2025
| @@ -0,0 +1,58 @@ | |||
| --- | |||
| description: node-fetch was a package created for fetch to run in node (similar to cross-fetch but cross-fetch is to work equal in browser and server), it has still millions of downloads even if fetch since 18 (experimental) and 21 (stable) supports fetch API | |||
Contributor
There was a problem hiding this comment.
the description is used for embeds etc, its meant to be more concise. see the axios one for example:
---
description: Modern alternatives to the axios package for making HTTP requests in browsers and Node.js
---
Contributor
|
i wonder if we should just have a we generally do one-to-one docs so we can show migration examples (rich diffs). but in this case, there are no diffs, rather just basic examples. so we probably could have one doc thoughts? would be nice to get the opinion of someone like @outslept or @Fuzzyma too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding node-fetch and cross-fetch to the module replacements, with this we have modules that will require the same replacements how should we share that part ? Should we do it like lodash/underscore example ?
I also created issues in the respective repositories as it would be nice to warn users about not needing the modules depending on their engines:
node-fetch/node-fetch#1857
lquixada/cross-fetch#209
Closes #269 #268