fix: reject inbound webhooks when auth credentials are missing#5
Merged
Conversation
Member
mpge
commented
Feb 15, 2026
mpge
commented
- Mailgun: return false (was return true) when signing key is not configured
- Mailgun: add 5-minute timestamp freshness window for replay protection
- Mailgun: use timingSafeEqual for constant-time signature comparison
- Postmark: require configured token via basic auth (was unconditional return true)
- SES: require TopicArn match and validate SigningCertURL domain (was unconditional return true)
- Mailgun: return false (was return true) when signing key is not configured - Mailgun: add 5-minute timestamp freshness window for replay protection - Mailgun: use timingSafeEqual for constant-time signature comparison - Postmark: require configured token via basic auth (was unconditional return true) - SES: require TopicArn match and validate SigningCertURL domain (was unconditional return true)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.