feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18488516317Details
💛 - Coveralls |
1 task
aladdin-add
force-pushed
the
feat/drop-node-18
branch
from
e723e0e to
9d08cb1
Compare
fasttime
reviewed
Oct 27, 2025
.github/workflows/build.yml
Outdated
| - 22 | ||
| - 24 | ||
| - 25 | ||
| node: [25.x, 24.x, 22.x, 20.x, "20.19.0"] |
There was a problem hiding this comment.
I think PRIMARY_NODEJS_VERSION should be also changed to match one of the values in this list.
csstree/.github/workflows/build.yml
Line 8 in 9d08cb1
That could fix the CI failure, or result in a different error.
Updated Node.js version in the build workflow and adjusted conditions for running tests and coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Updated package.json of the package to require:
"node": "^20.19.0 || ^22.13.0 || >=24"
This drops support for Node.js 18.
What changes did you make? (Give an overview)
Related Issues
refs eslint/eslint#19969
Is there anything you'd like reviewers to focus on?