Skip to content

Bug safari with Content-Encoding: gzip and Content-Disposition #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Bug safari with Content-Encoding: gzip and Content-Disposition #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00f07cd
bug safari and wrong buf
Apr 27, 2023
7795d4f
Merge branch 'esphome:master' into master
xlyric Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/WebResponses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ AsyncFileResponse::AsyncFileResponse(FS &fs, const String& path, const String& c
// set filename and force rendering
snprintf(buf, sizeof (buf), "inline; filename=\"%s\"", filename);
}
addHeader("Content-Disposition", buf);
// addHeader("Content-Disposition", buf);
}

AsyncFileResponse::AsyncFileResponse(File content, const String& path, const String& contentType, bool download, AwsTemplateProcessor callback): AsyncAbstractResponse(callback){
Expand Down Expand Up @@ -566,7 +566,7 @@ AsyncFileResponse::AsyncFileResponse(File content, const String& path, const Str
} else {
snprintf(buf, sizeof (buf), "inline; filename=\"%s\"", filename);
}
addHeader("Content-Disposition", buf);
//addHeader("Content-Disposition", buf);
}

size_t AsyncFileResponse::_fillBuffer(uint8_t *data, size_t len){
Expand Down