Skip to content

Conversation

@philipeleandro
Copy link
Collaborator

No description provided.

@philipeleandro philipeleandro self-assigned this Nov 5, 2023
Copy link
Collaborator

@danielnottingham danielnottingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked your solution! Maybe you could consider adding some test cases:
'imports a valid CSV file'
'handles an empty CSV file'
'returns an error for non-CSV files'

here I'm not sure if it's worth adding a test for this:

def encode_string(string)
  string.force_encoding("ISO-8859-1").encode("UTF-8")
end

'handle CSV files that contain special characters'

@philipeleandro
Copy link
Collaborator Author

@danielnottingham thanks! I created the PR and I forgot to add tests. Soon I'll add the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants