Add get_digital_data_sincelast to librador#205
Draft
couchand wants to merge 1 commit intoespotek-org:masterfrom
Draft
Add get_digital_data_sincelast to librador#205couchand wants to merge 1 commit intoespotek-org:masterfrom
couchand wants to merge 1 commit intoespotek-org:masterfrom
Conversation
Collaborator
|
Honestly man, any new feature that is added to the API is awesome! Let us know when you're ready to pull and I'll push it through. |
Contributor
|
@couchand appreciate your contribution, but it's state is unclear currently. |
Contributor
Author
|
Hi @mi-hol, to be honest there is just so much I've wanted to be doing with this beautiful little device but I haven't gotten around to any of it recently, unfortunately. I'd love to pick this up again, not sure when that will be. Happy to answer any questions if you'd like to take it over! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To mirror the
get_analog_data_sincelastmethod on the digital side, I've added the functionget_digital_data_sincelast.I've made a mistake in the math that I have yet to identify -- it's not yet returning the right number of subsamples. I will work that out and update this PR.
In the meantime, I thought I would open a draft here, to get your thoughts on adding this to the API. Let me know what you think!