Skip to content

Fix conditional checks for code signing #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mi-hol merged 1 commit into from
Feb 22, 2026
Merged

Fix conditional checks for code signing #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:

- name: Code sign app bundle
working-directory: Desktop_Interface
if: ( env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != '' )
if: env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != ''
run: |
# Find the signing identity
IDENTITY=$(security find-identity -v -p codesigning | grep "Developer ID Application" | head -1 | awk -F'"' '{print $2}')
Expand All @@ -101,7 +101,7 @@ jobs:

- name: Create and sign DMG
working-directory: Desktop_Interface
if: ( env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != '' )
if: env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != ''
run: |
# Get the git hash for the filename
GIT_HASH=$(git rev-parse --short HEAD)
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
if: ( env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != '' )
if: env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != ''
run: |
GIT_HASH=$(git rev-parse --short HEAD)
DMG_PATH="Labrador-${GIT_HASH}.dmg"
Expand All @@ -155,7 +155,7 @@ jobs:
spctl -a -vvv -t install "$DMG_PATH"

- name: Upload artifacts
if: ( env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != '' )
if: env.MACOS_CERTIFICATE != '' && env.MACOS_CERTIFICATE_PWD != ''
uses: actions/upload-artifact@v4
with:
name: asset-dmg
Expand Down