-
Notifications
You must be signed in to change notification settings - Fork 37
refactor(usb_host): Removed parent_dev_hdl and parent_port_num from Enum Driver (part1/4) #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tore-espressif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roma-jam LGTM. What is the reason for targeting refactor/usb_host_parent_child_deps instead of master?
peter-marcisovsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor corrections
|
the goal is to remove the As we do not have the external hubs verification in CI, I did it manually (launch the pytest) and only for the last (part4/4) MR, which delivers the complete refactoring. So, as reviewing the large amount of changes can provide difficulties and hide the main idea of the changes, I decided to split them to several logically independent PRs, targeting to a separate branch, to merge this branch later to master (with full refactoring in all layers). UPD: but actually, I reviewed the changes in this exactly PR, keeping in mind your note and I see, that this one can be merged directly to master. |
|
@roma-jam up to you. I agree that this 1st PR is simple enough and can be merged to master after 1.0.1 release |
|
@tore-espressif I checked the usb_host test locally and we can change the target branch to master for with one.
I have created the next milestone after 1.0.1 release for this case. |
138be1b to
37de6d7
Compare
…with node uid - Changed the interaction between two layers: Enum and Hub. Instead of keeping the parent_dev_hdl and parent_port_num the Enumerator operates with node_uid.
37de6d7 to
257d193
Compare
Description
Removed parent device information from the Enumeration Driver. The Driver operates only with device tree node and its uid.
Related
Testing
USB Host target tests with and without external hub.
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Switches Enum and Hub to operate by device-tree node UID, renaming hub_port_* -> hub_node_* and simplifying enum events to carry node_uid/dev_hdl.
enum_event_data_tsimplified toevent,node_uid,dev_hdl; per-event unions and parent port fields removed.hub_port_{recycle,reset,active,disable}->hub_node_{recycle,reset,active,disable}; params nownode_uid; addESP_ERR_NOT_FOUNDwhen node missing.dev_tree_node_get_by_uid()and use node-based operations for root/external hubs in recycle/reset/active/disable paths.node_uidinstead of parent handle/port; update event emissions (started/reset-required/completed/canceled) and logging; cleanup state accordingly.hub_node_*and new enum event data; onDEV_FREEcallhub_node_recycle(uid).Written by Cursor Bugbot for commit 257d193. This will update automatically on new commits. Configure here.