-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New apps: bmoface, doomguy, and meseeks! #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New commit with app.png and hopefully all errors cleared.
Committing BMOface, Doomguy, and Mr MeSeeks, hopefully all errors have finally been cleared.
|
Never stop improving :) |
|
These look really nice :) |
|
Thanks for the apps! They appear to all be the same code but a different app for different images, are you able to combine them into one app? Perhaps that the user can select between when they install? |
|
I suppose I could, however these are three completely unrelated character themes, with different offerings on the clock info placement and interactivity. If you just want to switch between the faces/clocks, there are a couple apps that allow you to either schedule clocks, or cycle through them with a tap. |
|
Fair enough - I'll merge (once the lint is ok) but please bear in mind there's been 5 PRs, which I've read through all as they go, and each app is ~700 lines of code, so combined this takes up a lot of maintainer free-time |
Sorry about it being 3 apps at once. I finally figured out how to run the npm test locally and worked on it until the errors were cleared.
|
I notice |
|
*facepalm* No, I didn't mean to add that one yet.
Would it be best at this time to cancel this one and retry with the 3 separate pull requests?
Lucien Storm
On October 30, 2025 8:08:21 AM CDT, Rob Pilling ***@***.***> wrote:
bobrippling left a comment (espruino/BangleApps#4041)
I notice `stardateclock_wbin` has appeared - did you mean to add that too?
--
Reply to this email directly or view it on GitHub:
#4041 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
Through K-9 Mail on Android
|
|
Nah that's alright - I can tinker with the commits and just do the three if you're ok with that? |
No description provided.