Skip to content

Conversation

@travjenkins
Copy link
Member

@travjenkins travjenkins commented Dec 16, 2025

Issues

#1821

Changes

1821

  • Hide the oneOf discriminator input
  • Do not prompt for clearing data when it is not necessary

Tests

Manually tested

Lots of connectors

Used the following query and tested 30+ connectors. This seems to hit most of the patterns I could see. The main two examples are connector schemas with credentials or parser.

SELECT connector_id, documentation_url, endpoint_spec_schema
FROM connector_tags
WHERE endpoint_spec_schema::text LIKE '%"discriminator"%';

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

No discriminator being displayed

image image

Only prompt to clear data when something that contains a value or isn't going to be injected is changed.

image image

@travjenkins travjenkins changed the title Travjenkins/ux/hide auth type dropdown Hide discriminator props when rendering Dec 17, 2025
setOpen(false);
}, [setOpen]);

const possibleSchemas = (schema as JsonSchema).oneOf as JsonSchema[];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pull this out now so we can reference it down below during defaulting.

@travjenkins travjenkins marked this pull request as ready for review December 17, 2025 21:30
@travjenkins travjenkins requested a review from a team as a code owner December 17, 2025 21:30
@travjenkins travjenkins added the change:planned This is a planned change label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:planned This is a planned change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants