Add support for IE 9++ (maybe even 8) + Add possibility to specify encod... #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coding of the generated csv file
cannot open cvs with ng-export instead of export-cvs
|
Since this repo was not being updated, we forked it and would welcome suggestions like these that could improve the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ing of the generated csv file
Being able to specify the encoding is important if you intend to provide csv files for Excel 2007 as it expects them to be in latin1.
As it turns out, the other PR from @erdraug fixes the problem for Excel 2007 as well: #10
Nevertheless, it might be nice to be able to specify the output encoding.
If you don't like this, please tell me and I'll provide a patch which will only fix the IE export issue.