Skip to content

Conversation

@Stane034
Copy link

No description provided.

Copy link
Member

@Kr3mu Kr3mu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to mantine a function functioName standard instead of functionName = function across the lib, so if you could change it. Also you do checking for modelHash in requestmodel but not in the requestWeaponAsset. Instead of adding iferrorMessage you can just do {"string", "nil"}. In my opinion and default timeout of 10000 or don't make it optional.

@Kr3mu
Copy link
Member

Kr3mu commented Nov 5, 2025

nvm make it optional because of backwards compatibility

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Stane034
❌ Zykem
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants