Add more extensive runtime metrics #21029
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tjungblu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 35 files with indirect coverage changes @@ Coverage Diff @@
## main #21029 +/- ##
==========================================
- Coverage 69.18% 68.87% -0.32%
==========================================
Files 422 429 +7
Lines 34841 35755 +914
==========================================
+ Hits 24104 24625 +521
- Misses 9335 9723 +388
- Partials 1402 1407 +5 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
I've noticed that K8s and apiserver contains several metrics that etcd does not have. This PR adds the missing metrics to the default Prometheus registry. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
tjungblu
force-pushed
the
gogc_metrics
branch
from
d418c87 to
1e457e3
Compare
|
/retest |
|
|
||
| func init() { | ||
| // register more extensive go runtime metrics, for that we need to unregister the default metrics first | ||
| prometheus.Unregister(collectors.NewGoCollector()) |
There was a problem hiding this comment.
I haven't diged into the implementation of prometheus.Unregister, but you unregister a newly created objerct collectors.NewGoCollector() instead of the existing already registered one, are you sure it's correct?
There was a problem hiding this comment.
Yes. The registry works by the metric name, so it will list all the metric names and remove them. It doesn't refer to the metrics by their references or addresses.
The duplication logic that returns errors on duplicate registers also goes via names.
|
/retest |
4 participants
I've noticed that K8s and apiserver contains several metrics that etcd does not have. This PR adds the missing metrics to the default Prometheus registry.