Native account abstraction rev 1#2
Merged
forshtat merged 9 commits intonative_account_abstractionfrom Oct 10, 2023
Merged
Conversation
yoavw
reviewed
Oct 7, 2023
yoavw
left a comment
yoavw
left a comment
There was a problem hiding this comment.
Only wrote one comment inside. And the diagrams are a great addition.
However, it seems to still be missing some of the things that came up in comments on PR #1. E.g. callGasLimit - calldataCost (unless you think it's wrong). Let's make sure we covered all of them.
EIPS/eip-00.md
Outdated
|
|
||
| Here is a visual representation of a block that contains multiple Account Abstraction Transactions. | ||
| The validation parts of AA transactions are executed in a separate position in a block, but are not considered | ||
| to be separate a transaction: |
There was a problem hiding this comment.
Would it be clearer if we write "The validation parts of AA transactions are executed as separate transactions, but are not represented as separate transactions in the block data." ?
Also, rephrase the validation phase description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: