This repository was archived by the owner on Dec 2, 2024. It is now read-only.
sheret v1.22 -- new smaller dependency and compilable with newer go versions #9
Open
elmkni wants to merge 23 commits intoethanpil:masterfrom
Open
sheret v1.22 -- new smaller dependency and compilable with newer go versions #9elmkni wants to merge 23 commits intoethanpil:masterfrom
elmkni wants to merge 23 commits intoethanpil:masterfrom
Conversation
Replaced import of "github.com/pkg/browser" with "github.com/icza/gox/osx" because it is much smaller! Also changed 'browser.OpenURL' to 'osx.OpenDefault'.
Changed require github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 require golang.org/x/sys v0.0.0-20210616045830-e2b7044e8c71 // indirect to require github.com/icza/gox v0.0.0-20230330130131-23e1aaac139e
changed github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 h1:KoWmjvw+nsYOo29YJK9vDA65RGE3NrOnUtO7a+RF9HU= github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8/go.mod h1:HKlIX3XHQyzLZPlr7++PzdhaXEj94dEiJgZDTsxEqUI= golang.org/x/sys v0.0.0-20210616045830-e2b7044e8c71 h1:X/2sJAybVknnUnV7AD2HdT6rm2p5BP6eH2j+igduWgk= golang.org/x/sys v0.0.0-20210616045830-e2b7044e8c71/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= to github.com/icza/gox v0.0.0-20230330130131-23e1aaac139e h1:aIs1rPxsH8t12+eWzEfrvK2o99fwiC0P9Qr8roW0vsU= github.com/icza/gox v0.0.0-20230330130131-23e1aaac139e/go.mod h1:VbcN86fRkkUMPX2ufM85Um8zFndLZswoIW1eYtpAcVk=
Added 'license.golang' and 'license.gox'. Renamed 'license' to 'license.sheret'. Changed '../' to '..\', for windows wants backward slashes!
bumped version from '1.2' to '1.22' to reflect the changes I made!
elmkni
changed the title
Author
You may now merge my pull-request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ethan,
I've changed the dependencies from "github.com/pkg/browser" to "github.com/icza/gox/osx" because it is much smaller and has no sub-dependency itself!
I've added the missing licenses for Go and Gox (they are actually compulsory) and edited 'release.bat' accordingly.
I've also bumped the version from '1.2' to '1.22' to reflect the changes I made!
I've also added two missing files to the root directory: 'go.mod' and 'go.sum'.
Those are needed to compile 'sheret' with newer go versions. Otherwise one gets:
no required module provides package github.com/icza/gox/osx: go.mod file not found;This should fix issue #4!
With best regards,
Elmar