Add TurkChain (EIP155-1919)#8107
Add TurkChain (EIP155-1919)#8107Turkchain1919 wants to merge 9 commits intoethereum-lists:masterfrom
Conversation
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
Turkchain1919
left a comment
Turkchain1919
left a comment
There was a problem hiding this comment.
Rpc adress update https://rpc.turkscan.com
|
Hello, the required checks are still waiting for maintainer approval to start. |
|
Hello maintainers, The RPC endpoint and metadata have been updated and the chain is fully operational. It seems the required checks are waiting for workflow approval, so the CI has not started yet. Could a maintainer please approve the workflows so the checks can run? Thank you. |
|
It has been updated, you can check again. |
|
Hi @ligi I have updated the JSON file multiple times to match the repository's required format and fixed all syntax errors. However, the "Run prettier check" is still failing in the CI pipeline. Could you please check the current state of PR and let me know exactly where the issue is? I want to ensure everything is correct, but I need your guidance on what specifically needs to be changed to get the green light. Thank you for your time. |
|
@ligi I just force-pushed the locally formatted version (using prettier). Ready for review! |
ligi
left a comment
ligi
left a comment
There was a problem hiding this comment.
icon URL MUST start with ipfs://
Thank you , We corrected the error. |
2 participants
Description
This PR adds the TurkChain configuration to the Ethereum lists. TurkChain is an EVM-compatible chain built on Cosmos SDK.
Chain Details:
The metadata includes both the chain configuration and the icon assets. All automated checks (CI) should pass as the formats follow the repository standards.