Modify path to use Crypto and Cryptodome#65
Modify path to use Crypto and Cryptodome#65manuwarfare wants to merge 2 commits intoethereum:mainfrom
Conversation
|
It looks like we'd need to install |
Thanks for your reply... The problem is that @sorenstoutner and I are packaging eth-hash for Debian, and pycryptodomex isn't in Debian. Only pycryptodome, which provides the Cryptodome namespace, is available. This patch allows the use of both Crypto and Cryptodome namespaces. This way, we were able to package eth-hash without any issues. However, it's necessary for (you) the upstream to thoroughly review the changes. |
This makes sense so that users who get the package through the traditional means can choose to use |
Soren and I have already updated this PR to include the necessary changes in setup.py to support pycryptodomex. |
On Debian, the expected path is Cryptodome. I made a small adjustment so that the scripts use both Crypto and Cryptodome paths.
Please consider carefully evaluating this change and accepting this PR if you are interested. If there is anything wrong with it, let me know.
Regards,