This repository was archived by the owner on Dec 17, 2024. It is now read-only.
Open
Conversation
32ab4a5 to
e25aebf
Compare
directives related to runtime & C99 header inclusion should use __GNU__, to make compiling with GNU compilers on Windows possible.
e25aebf to
cf1ecd2
Compare
Author
Member
|
What kind of warning? |
Member
|
BTW, I will be starting adding Python bindings to https://github.com/chfast/ethash. |
Author
|
@chfast Regarding the build warnings, it's worth noting that MSVC at Your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows ethash to build with MSVC under Windows.
I have built & installed the python package derived from this repository (pyethash) under Windows 10 and Fedora Linux without issue.
MSVC's /Wall does generate a number of informational compiler warnings, none of which appear new or appear serious.