-
Notifications
You must be signed in to change notification settings - Fork 5.3k
/what-is-ether page #16389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/what-is-ether page #16389
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @corwintines! Left a few code-related comments... @konopkja also left a handful of content-related comments, but overall looking good 🚀
src/intl/en/page-what-is-ether.json
Outdated
| "page-what-is-ether-l2s-description-4": "L2 <strong>transfers can cost as little as $0.04</strong>, bringing Ethereum to millions more users through integrations with companies like Robinhood, PayPal, and Shopify.", | ||
| "page-what-is-ether-what-is-the-eth-supply": "What is the ETH supply?", | ||
| "page-what-is-ether-what-is-the-eth-supply-description-1": "Unlike Bitcoin's fixed 21 million cap, ETH has dynamic supply mechanics:", | ||
| "page-what-is-ether-what-is-the-eth-supply-description-2": "New ETH is issued to reward network validators", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to adjust wording to convey that this is rate-limited and based on amount of ETH staked.
Perhaps:
New ETH is issued to reward network validators at a limited rate calculated by the protocol
May be too much for here though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me
src/intl/en/page-what-is-ether.json
Outdated
| "page-what-is-ether-breakdown-description-3": "<strong>Smart contracts</strong>: Significant amounts in smart contracts including DeFi protocols", | ||
| "page-what-is-ether-breakdown-description-4": "<strong>Ethereum Foundation</strong>: Holds <ef>less than 0.3%</ef> of supply (down from 9% in 2014)", | ||
| "page-what-is-ether-who-holds-most": "Who holds the most?", | ||
| "page-what-is-ether-who-holds-most-description-1": "The largest address is the Beacon Deposit contract, representing millions of stakers rather than a single entity.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this is fuzzy... ETH in the deposit contract does not count to total supply... it's a one-way bridge... deposits are effectively burned, and the beacon chain mints an equivalent amount in exchange, designates it to a specific account, and takes over accounting for this ETH. This is not "owned" by the contract or any single entity, it's re-allocated amongst individual validator accounts.
That contract is up-only and could theoretically have unlimited ETH if folks continued to deposit to a validator, withdrawal it back to another account, and re-deposit it. Same ETH, but that contract will continue to inflate.
Would not cite this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm @mnelsonBT if we wanted to change this small section "Who holds the most" , what would you do with it?
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
Co-authored-by: Melissa Nelson <mfnpublishing@gmail.com>
…org-website into what-is-ether
wackerow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "page-what-is-ether-what-is-the-distribution-of-eth-description-1": "Ownership is widely distributed across <etherscan>tens of millions of addresses</etherscan>, preventing concentration of control and enhancing decentralization.", | ||
| "page-what-is-ether-breakdown": "A breakdown of ether distribution", | ||
| "page-what-is-ether-breakdown-description-1": "<strong>Staked ether</strong>: Tens-of-millions of ETH <beaconchain>locked</beaconchain> for network security", | ||
| "page-what-is-ether-breakdown-description-2": "<strong>Exchanges</strong>: Centralized platforms <unchained>hold 13-16%</unchained> of supply", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking suggestion:
| "page-what-is-ether-breakdown-description-2": "<strong>Exchanges</strong>: Centralized platforms <unchained>hold 13-16%</unchained> of supply", | |
| "page-what-is-ether-breakdown-description-2": "<strong>Exchanges</strong>: Centralized platforms <unchained>hold 13-16%</unchained> of supply for their users", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment below - some changes pushed pre-devconnect don't seem to be reflected here
src/intl/en/page-what-is-ether.json
Outdated
| "page-what-is-ether-who-holds-most": "Who holds the most?", | ||
| "page-what-is-ether-who-holds-most-description-1": "The Ethereum addresses with the highest ETH balances are typically not individuals. The vast majority of ether visible in the \"top\" Ethereum addresses represents the collective, pooled funds of many different people and entities, not the holdings of a single individual. ", | ||
| "page-what-is-ether-who-holds-most-description-2": "The highest-balance ETH accounts typically include:", | ||
| "page-what-is-ether-who-holds-most-description-3": "The Beacon Chain Deposit Contract: The deposit contract's balance represents all of the ETH that has been <staked>staked</staked> to help secure the Ethereum network. While this is the Ethereum address with the largest ETH balance, it does not represent an accessible Ethereum wallet account. It is a smart contract that accepts deposits of ETH as the first step to participate in staking, then manages the balances of that ether across the network's active validators. The ETH balance in the contract is owned and controlled by millions of stakers and node operators around the world.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ETH balance in the contract is owned and controlled by millions of stakers and node operators around the world.
😕 It really isn't though... Quick example:
- 10 million ETH are deposited
- 10 million ETH is allocated to beacon chain validator accounts, while balance of deposit contract remains 10 million
- That 10 million ETH is exited and withdrawn to regular accounts (those validator balances go to zero, but the deposit contract still says 10 million)
- Repeat those steps 10 times
- Deposit contract says 100 million ETH, yet nobody owns any of it, nor does that 100 million actually mean anything for the total ETH in existence
This is tricky, since block explorers don't really distinguish this nuance. It's literally just a one-way bridge that might as well have a balance of zero.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @wackerow - I think that is clear enough if we just delete "The ETH balance in the contract is owned and controlled by millions of stakers and node operators around the world."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And leave it as just:
"The Beacon Chain Deposit Contract: The deposit contract's balance represents all of the ETH that has been staked to help secure the Ethereum network. While this is the Ethereum address with the largest ETH balance, it does not represent an accessible Ethereum wallet account. It is a smart contract that accepts deposits of ETH as the first step to participate in staking, then manages the balances of that ether across the network's active validators."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm aligned with that, thanks!
Co-authored-by: mnelsonBT <74370515+mnelsonBT@users.noreply.github.com>
wackerow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corwintines Patched those final adjustments... don't see any other blockers so think this is ready to go and can iterate as-needed from there 🚀


Creates new /what-is-ether page
Preview link
https://deploy-preview-16389--ethereumorg.netlify.app/what-is-ether