bug(test-cli-fill): Use default evm-dump-dir for traces; gitignore it #1852
+24
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
--traceswith--evm-dump-diris currently broken due to improperLazyAllochandling. This PR fixes it by validating withget()and properly serializing viamodel_dump_json.--evm-dump-diroftraces/which is also in.gitignoreso we don't have to keep removing it from the working dir. Previously,--tracesdid absolutely nothing without a specified--evm-dump-dirbut it also didn't tell you anything in the cli if you did this, which is quite confusing DevEx.🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture