Grammar & Consistency Fixes for Clarity#64
Open
SITADRITA1 wants to merge 3 commits intoethereum:mainfrom
Open
Conversation
adrianmcli
requested changes
Mar 2, 2025
Contributor
adrianmcli
left a comment
adrianmcli
left a comment
There was a problem hiding this comment.
Thanks for this! I agree with all changes except for the one in the README.
The original sentence is correct because 'they' refers to 'your changes,' which is plural. Changing it to 'it' creates a mismatch since there's no singular noun to refer to. To maintain proper agreement, 'they will be approved' should remain as is.
Author
Contributor
|
I think you still haven't made the change I requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File: README.md
Old: Mention any related issues here, using the #issue_number syntax.
New: Mention related issues here, using the #issue_number syntax.
Reason: Improved readability by making the sentence more concise.
File: Module 1 - Basics.md
Old: Since the results of the third and fourth calculations match, they do follow a "group structure." Notice that, it doesn't matter...
New: Since the results of the third and fourth calculations match, they follow a "group structure." Notice that it doesn't matter...
Reason: Removed unnecessary "do" for proper sentence structure and removed an unnecessary comma.
File: CONTRIBUTING.md
Old: Submit Pull Requests: Submit a pull request with your changes once you are confident they will be approved.
New: Submit Pull Requests: Submit a pull request with your changes once you are confident it will be approved.
Reason: Changed "they" to "it" for correct singular agreement.