fix: resolve DataTable UI issues - sorting indicators, column resizing, and alignment#73
Merged
christoph2806 merged 9 commits intodevelopfrom Jun 13, 2025
Merged
Conversation
added 9 commits
June 13, 2025 16:00
…rs, number alignment, and column resizing
…- add sorting and columnSizing state to headerGroups dependencies - improve resize handle visibility with better styling and width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #73: Fix DataTable UI Issues - Sorting, Resizing, and Alignment
🎯 Overview
This hotfix resolves three critical DataTable UI issues reported by the web app team, improving the overall user experience and functionality of the DataTable component.
🐛 Issues Fixed
Issue #70: Missing Sorting Indicators ✅
headerGroupsto ensure sorting indicators update properlyChevronsUpDown(opacity 50%) for sortable but unsorted columnsChevronUpfor ascending sortChevronDownfor descending sortIssue #71: Number Column Right Alignment Not Working ✅
meta.className: 'text-right'was not being applied to table cellsmeta.classNamepropertymeta.classNameusingcn()utilityColumnMetaIssue #72: Column Resizing Handles Not Working ✅
columnSizingstate andonColumnSizingChangecallbackw-1tow-2for better visibilitybg-bordertobg-muted-foreground/20🔧 Additional Improvements
Custom SVG Icon Replacement
SunandMooniconsChevronRighticonAlertTriangleiconEnhanced DataTable Stories
🧪 Testing
📊 Verification
The updated Storybook now properly demonstrates:
✅ Sorting Indicators:
ChevronsUpDownwhen unsortedChevronUporChevronDown✅ Column Resizing:
✅ Text Alignment:
🚀 Impact
📝 Breaking Changes
None. All changes are backward compatible.
🔗 Related Issues
📋 Checklist