Skip to content

refactor #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ping-ke wants to merge 18 commits into
base: main
Choose a base branch
from
Open

refactor #466

ping-ke wants to merge 18 commits into from

Conversation

@ping-ke
Copy link
Collaborator

@ping-ke ping-ke commented Sep 29, 2025 •
edited
Loading

Changes:

  1. Try to use PollingClient code instead of reimplementing it.
  2. Rename conflicting variables: new -> n and result -> r (result is a struct name)

@ping-ke ping-ke marked this pull request as draft September 29, 2025 10:51
@ping-ke ping-ke marked this pull request as ready for review September 29, 2025 16:50
@ping-ke ping-ke mentioned this pull request Sep 30, 2025
Closed
syntrust
syntrust reviewed Sep 30, 2025
View reviewed changes
@syntrust
Copy link
Collaborator

syntrust commented Sep 30, 2025

Any tests done to cover the changes?

@ping-ke
Copy link
Collaborator Author

ping-ke commented Oct 9, 2025 •
edited
Loading

It has passed the regular unit tests and there is also a node running based on this code.

@ping-ke ping-ke requested a review from syntrust October 9, 2025 09:07
@qzhodl qzhodl mentioned this pull request Oct 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syntrust syntrust syntrust approved these changes

@qizhou qizhou Awaiting requested review from qizhou

@qzhodl qzhodl Awaiting requested review from qzhodl

@iteyelmp iteyelmp Awaiting requested review from iteyelmp

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ping-ke @syntrust