refactor: replace Split in loops with more efficient SplitSeq

cmd/alert/main.go

@@ -115,9 +115,9 @@ func writeHtmlFile(content string, lg log.Logger) {
 }
 
 func addToEmailList(emailList map[string]struct{}, emailToString string) {
-	emails := strings.Split(emailToString, ",")
+	emails := strings.SplitSeq(emailToString, ",")
 
-	for _, email := range emails {
+	for email := range emails {
 		emailList[email] = struct{}{}
 	}
 }

cmd/priv-dashboard/main.go

@@ -219,8 +219,8 @@ func (d *dashboard) Report() {
 
 	if *emailEnableFlag && time.Now().After(d.lastNotification.Add(emailReportInterval)) {
 		contracts := make(map[string]struct{})
-		cs := strings.Split(*emailContractsFlag, ",")
-		for _, c := range cs {
+		cs := strings.SplitSeq(*emailContractsFlag, ",")
+		for c := range cs {
 			c = strings.TrimSpace(c)
 			if c == "" { // ignore empty records
 				continue

ethstorage/flags/types/flags_types.go

@@ -110,8 +110,8 @@ func (b *bigValue) Set(s string) error {
 }
 
 func eachName(f cli.Flag, fn func(string)) {
-	parts := strings.Split(f.GetName(), ",")
-	for _, name := range parts {
+	parts := strings.SplitSeq(f.GetName(), ",")
+	for name := range parts {
 		name = strings.Trim(name, " ")
 		fn(name)
 	}

ethstorage/p2p/cli/load_config.go

@@ -240,7 +240,7 @@ func loadLibp2pOpts(conf *p2p.Config, ctx *cli.Context) error {
 		conf.StaticPeers = append(conf.StaticPeers, a)
 	}
 
-	for _, v := range strings.Split(ctx.GlobalString(flags.HostMux.Name), ",") {
+	for v := range strings.SplitSeq(ctx.GlobalString(flags.HostMux.Name), ",") {
 		v = strings.ToLower(strings.TrimSpace(v))
 		switch v {
 		case "yamux":

ethstorage/p2p/peer_scorer.go

@@ -37,7 +37,7 @@ func NewBandScorer(str string) (*BandScoreThresholds, error) {
 		bands: make([]scorePair, 0),
 	}
 
-	for _, band := range strings.Split(str, ";") {
+	for band := range strings.SplitSeq(str, ";") {
 		// Skip empty band strings.
 		band := strings.TrimSpace(band)
 		if band == "" {