Skip to content

chore: minor improvement for docs #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qzhodl merged 3 commits into from
Dec 23, 2025
+3 −3
Merged

chore: minor improvement for docs #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18f6472
chore: minor improvement for docs
rustversion Nov 9, 2025
3c0f132
Merge branch 'main' into main
ping-ke Dec 22, 2025
1aea9ac
Merge branch 'main' into main
qzhodl Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethstorage/data_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ type DataFileHeader struct {
status uint64
}

// Mask the data in place. Padding zeros to userData if the len of userData is smaller than that of maskData,
// Mask the data in place. Padding zeros to userData if the len of userData is smaller than that of maskData.
func MaskDataInPlace(maskData []byte, userData []byte) []byte {
if len(userData) > len(maskData) {
panic("user data can not be larger than mask data")
Expand Down
4 changes: 2 additions & 2 deletions ethstorage/p2p/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ func (n *NodeP2P) init(resourcesCtx context.Context, chainID *big.Int, lg log.Lo
)
css, err := n.Host().Peerstore().Get(remotePeerId, protocol.EthStorageENRKey)
if err != nil {
// for node which is new to the ethstorage network, and it dial the nodes which do not contain
// the new node's enr, so the nodes do not know its shard list from enr, so it needs to call
// For nodes new to the ethstorage network that dial nodes which do not contain
// the new node's enr, the nodes do not know its shard list from enr, so it needs to call
// n.RequestShardList to fetch the shard list of the new node.
remoteShardList, e := n.RequestShardList(remotePeerId)
if e != nil && len(n.host.Peerstore().Addrs(remotePeerId)) == 0 {
Expand Down
Loading