-
Notifications
You must be signed in to change notification settings - Fork 98
Email alert when blob missing from CL #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| s.lg.Error("Did not find the event specified blob in the CL") | ||
|
|
||
| s.notifyBlobMissing(elBlock.number, elBlob.kvIndex.Uint64(), elBlob.hash) | ||
| s.lg.Crit("Did not find the event specified blob in the CL", "blockNumber", elBlock.number, "kvIndex", elBlob.kvIndex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to lg.crit here, as it will cost es-node exit
func (l *logger) Crit(msg string, ctx ...interface{}) {
l.Write(LevelCrit, msg, ctx...)
os.Exit(1)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is precisely what is required by the issue. It is pointless to leave the node running in this situation, and the operator should be informed as soon as possible.
Fixes #480.
Reproduced by creating a new mainnet es-node and downloading blocks using
--download.start 23935930and--l1.beacon http://65.21.133.53:4200, as the blob at 23935934 was missing in 65.21.133.53.This fix has been verified in the same environment with and without email configured.
Email example: