Add support for choosing docker image from dockerhub tags at login#1
Draft
JaroCamphuijsen wants to merge 3 commits intomasterfrom
Draft
Add support for choosing docker image from dockerhub tags at login#1JaroCamphuijsen wants to merge 3 commits intomasterfrom
JaroCamphuijsen wants to merge 3 commits intomasterfrom
Conversation
Member
|
When this is ready it would be good to get a review from @evertrol and/or @nielsdrost and perhaps some help or instructions for actually deploying these changes on the virtual machine. |
Peter9192
changed the title
…ld document with docker image tags
Author
|
🦆🦆🦆hub 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for multiple docker images. This is useful, because users can then test an upgraded environment and identify issues before we switch definitively.
Followed the explanation in jupyterhub/dockerspawner#219 to implement a dropdown for choosing the docker image version in a dropdown at login. Under the hood this follows this documentation: https://jupyterhub.readthedocs.io/en/stable/reference/spawners.html#spawner-options-from-form