Conversation
evedovelli
requested changes
Oct 18, 2021
| ser2net, | ||
| username=username, | ||
| password=password, | ||
| pty_winsize_cols=SSH_PTY_WINSIZE_COLS, |
Owner
There was a problem hiding this comment.
Here you should import and use the PTY_WINSIZE_COLS from Ser2Net instead
| #################################################################################################### | ||
| ## Ser2NetLinux | ||
|
|
||
| class Ser2NetLinux(SshLinux): |
Owner
There was a problem hiding this comment.
Why is it extendind the SshLinux instead of Linux? Is it only for the implementation of the logout function? If so, move it to the Linux class and extend the Ser2NetLinux from Linux, because the SshLinux may have invalid methods for Ser2NetLinux in the future.
Author
There was a problem hiding this comment.
At first I tried to reuse the login function as well, but it needed some tuning for Ser2Net in the end. It does make more sense extending Linux, though.
|
|
||
| class Ser2NetLinux(SshLinux): | ||
| """ Connects to a remote Linux Shell using SSH. | ||
| Core implementation is done by Ssh and Linux. |
Owner
There was a problem hiding this comment.
Replace SSH with Ser2Net in the comments above
Also fix typos on connections/Ser2Net.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix typos on connections/Ser2Net.py.