Support nullable foreign keys with read_only=False#25
Open
fabricemarie wants to merge 1 commit intoevenicoulddoit:masterfrom
fabricemarie:writable_null_support
Open
Support nullable foreign keys with read_only=False#25fabricemarie wants to merge 1 commit intoevenicoulddoit:masterfrom fabricemarie:writable_null_support
fabricemarie wants to merge 1 commit intoevenicoulddoit:masterfrom
fabricemarie:writable_null_support
Conversation
Owner
evenicoulddoit
left a comment
evenicoulddoit
left a comment
There was a problem hiding this comment.
Thanks for doing this. Just one little gripe with the code, but also, I think this feature needs to be tested 👍
| utils.model_from_definition(field_definition['id_model']) | ||
| .objects.all() | ||
| ) | ||
| if 'allow_null' in field_definition.keys(): |
Owner
There was a problem hiding this comment.
Wouldn't this be better as field_definition.get('allow_null')?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.