Skip to content

V1: Update Elasticsearch to v1#1088

Closed
MMonrad wants to merge 6 commits intoeventflow:develop-v1from
MMonrad:v1-elastic-search
Closed

V1: Update Elasticsearch to v1#1088
MMonrad wants to merge 6 commits intoeventflow:develop-v1from
MMonrad:v1-elastic-search

Conversation

@MMonrad
Copy link
Contributor

@MMonrad MMonrad commented Mar 9, 2025

This PR is upgrading Elastic Search from v0 to v1

@MMonrad
Copy link
Contributor Author

MMonrad commented Mar 9, 2025

Hi @rasmus, I got some extra time so converted Elastic Search to v1, my plan is to convert from NEST to Elastic.Clients.Elasticsearch, as NEST is deprecated. It is coming in another PR :)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades ElasticSearch to v1 by updating configuration, dependency injection, and logging while modernizing asynchronous patterns in read model event handling and test setups.

  • Updated RELEASE_NOTES.md to announce the v1 port.
  • Refactored service registrations in EventFlowOptionsExtensions to use Microsoft.Extensions.DependencyInjection.
  • Converted read model event handlers to async methods and updated test configurations and logging.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
RELEASE_NOTES.md Added notification for the v1 port of EventFlow.Elasticsearch.
Source/EventFlow.Elasticsearch/Extensions/EventFlowOptionsExtensions.cs Replaced legacy service registration with Microsoft.Extensions.DependencyInjection and removed obsolete methods.
Source/EventFlow.Elasticsearch.Tests/IntegrationTests/ReadModels/ElasticsearchThingyMessageReadModel.cs Converted Apply methods to async for better compatibility with asynchronous operations.
Source/EventFlow.Elasticsearch.Tests/IntegrationTests/ElasticsearchReadModelStoreTests.cs Updated DI setup and test configuration to align with the new service registration patterns.
README.md Changed the status indicator for EventFlow.Elasticsearch to reflect v1 compatibility.
Source/EventFlow.Elasticsearch.Tests/IntegrationTests/ReadModels/ElasticsearchThingyReadModel.cs Updated asynchronous event handlers with cancellation tokens.
Source/EventFlow.Elasticsearch/ReadStores/ElasticsearchReadModelStore.cs Updated logging to use Microsoft.Extensions.Logging and switched to async alias lookup.

@rasmus
Copy link
Member

rasmus commented Mar 17, 2025

Thanks. I'll have a look. It really awesome to get some additional help as I was hitting a wall doing it all on my own lately. Getting some support really means a lot ❤️

@MMonrad
Copy link
Contributor Author

MMonrad commented Mar 17, 2025

Thanks. I'll have a look. It really awesome to get some additional help as I was hitting a wall doing it all on my own lately. Getting some support really means a lot ❤️

Its a awesome library you have been building! Happy to help :D

@rasmus rasmus changed the title V1: Update ElasticSearch to v1 V1: Update Elasticsearch to v1 May 29, 2025
@github-actions
Copy link

Hello there!

We hope this message finds you well. We wanted to let you know that we have noticed that there has been
no activity on this pull request for the past 90 days, which makes it a stale pull request.

As a result, we will be closing this pull request within the next seven days. If you still
think this pull request is necessary or relevant, please feel free to update it or leave a
comment within the next seven days.

Thank you for your contributions and understanding.

Best regards,
EventFlow

@github-actions github-actions bot added the stale label Aug 28, 2025
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

Hello there!
I'm a bot and I wanted to let you know that your pull request has been closed due to inactivity after being marked as stale for seven days.
If you believe this was done in error, or if you still plan to work on this pull request, please don't hesitate to reopen it and let us know. We're always happy to review and merge high-quality contributions.
Thank you for your interest in our project!
Best regards, EventFlow

@github-actions github-actions bot closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants