Fix: Hangfre backward compatibility with 0.x#1129
Merged
rasmus merged 4 commits intodevelop-v1from Oct 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Restore backward compatibility for Hangfire jobs enqueued with EventFlow.Hangfire 0.x by reintroducing obsolete overloads that forward to the current job runner API.
- Add two obsolete ExecuteAsync overloads to IHangfireJobRunner and HangfireJobRunner that match the 0.x signatures.
- Provide tests to verify legacy signatures exist and delegate to the modern implementation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/EventFlow.Hangfire/Integration/IHangfireJobRunner.cs | Reintroduces obsolete overloads on the interface to match 0.x serialized signatures. |
| Source/EventFlow.Hangfire/Integration/HangfireJobRunner.cs | Implements obsolete overloads that forward to the current ExecuteAsync, preserving behavior. |
| Source/EventFlow.Hangfire.Tests/Integration/HangfireJobRunnerBackwardCompatibilityTests.cs | Adds tests ensuring legacy signatures exist and delegate correctly. |
Suppress unused parameter warnings for displayName and queueName in obsolete methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1109