refactor(adapter): adapt signature payload provider for non aggregator#221
Merged
julienrbrt merged 11 commits intomainfrom Sep 1, 2025
Merged
refactor(adapter): adapt signature payload provider for non aggregator#221julienrbrt merged 11 commits intomainfrom
julienrbrt merged 11 commits intomainfrom
Conversation
- Bump github.com/evstack/ev-node to v1.0.0-beta.2.0.20250821181753-974aa15383de - Move cometcompat helpers to adapter package and update imports - Remove cometcompat package and related files - Add providers.go to adapter for signature and validator hash providers - Refactor usage across codebase to use adapter package functions
julienrbrt
changed the title
julienrbrt
added a commit
to evstack/ev-node
that referenced
this pull request
Sep 1, 2025
ev-abci needs to have some data in order to validate the header: https://github.com/evstack/ev-abci/blob/main/pkg/cometcompat/signer.go#L14-L36 However, ev-node can fetch a header without having its data, making the signature payload provider not working for syncing nodes from da. - Add set of signature payload providers for aggregator and sync node (a sync node needs the data to verify the header signature) - Refactor retrievers (store and da retriever) to pass down a full height to the sync loop (height + data), this allows to do the verification requirement above before passing it down to the sync block - rename some files for clarity related: evstack/ev-abci#221 ref: evstack/ev-abci#216
Member
Author
|
Migration tests failure can be ignored. Related to ignite/cli#4785 (comment). |
randygrok
approved these changes
Sep 1, 2025
chatton
pushed a commit
that referenced
this pull request
Oct 7, 2025
#221) * refactor(adapter): extract block id creation * Update ev-node version and refactor cometcompat to adapter - Bump github.com/evstack/ev-node to v1.0.0-beta.2.0.20250821181753-974aa15383de - Move cometcompat helpers to adapter package and update imports - Remove cometcompat package and related files - Add providers.go to adapter for signature and validator hash providers - Refactor usage across codebase to use adapter package functions * typo + issue * latest commit * fix height 1 blockid * updates * linting * bump ev node * bump again * bump to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract block id creation
Investigate how to create pass a block id when only a header is available from rollkit.
ref: #216, evstack/ev-node#2589