Skip to content

build(deps): bump to ev-node beta 9#296

Merged
julienrbrt merged 5 commits intomainfrom
julien/bump-v9
Nov 10, 2025
Merged

build(deps): bump to ev-node beta 9#296
julienrbrt merged 5 commits intomainfrom
julien/bump-v9

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 10, 2025

Overview

Bump to ev-abci v9.

@julienrbrt julienrbrt requested a review from a team as a code owner November 10, 2025 10:44
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the project's core ev-node and ev-node/core dependencies to their latest beta versions. This update necessitated several internal code adjustments, primarily to align with changes in the upstream library's API regarding block header and state management. The modifications simplify state initialization, refine header conversion logic, and update migration utilities to reflect the new data structures, ensuring compatibility and leveraging the latest features or fixes from the ev-node project.

Highlights

  • Dependency Updates: The primary change involves bumping the ev-node dependency to v1.0.0-beta.9 and ev-node/core to v1.0.0-beta.4 across the project, including the Dockerfile, go.mod, and tests/integration/go.mod files. This also includes updating the corresponding go.sum entries.
  • State Initialization Simplification: The lazy initialization logic for ev-abci state within the ExecuteTxs function in pkg/adapter/adapter.go has been removed, streamlining the state loading process.
  • Header Conversion Adjustments: Changes were made in pkg/adapter/convert.go to how ConsensusHash and LastResultsHash are handled during the conversion from ev-node headers to ABCI headers. ConsensusHash is now initialized with a new evtypes.Hash, and LastResultsHash is explicitly set to nil.
  • Migration Command Refinements: The server/migration_cmd.go and its corresponding test file server/migration_cmd_test.go have been updated to remove the LastCommitHash, ConsensusHash, and LastResultsHash fields during the conversion of CometBFT blocks to Rollkit signed headers, reflecting changes in the ev-node data structures.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/integration_test.yml
    • .github/workflows/migration_test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

if err != nil {
return nil, 0, fmt.Errorf("load state after init: %w", err)
}
return nil, 0, fmt.Errorf("load state: %w", err)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LastCommitHash: lastCommit.Hash(),
DataHash: cmbytes.HexBytes(header.DataHash),
ConsensusHash: cmbytes.HexBytes(header.ConsensusHash),
ConsensusHash: cmbytes.HexBytes(make(evtypes.Hash, 32)),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the ev-node dependency to v1.0.0-beta.9 and adapts the codebase to the corresponding API changes. The changes are consistent and well-executed.

Key changes include:

  • Updating the ev-node version in Dockerfile, go.mod, and tests/integration/go.mod.
  • Removing the lazy initialization logic for sync nodes in pkg/adapter/adapter.go, which simplifies the ExecuteTxs function. This is a welcome simplification, presumably enabled by the updated dependency.
  • Adapting to the removal of ConsensusHash, LastResultsHash, and LastCommitHash fields from ev-node types. This is reflected in pkg/adapter/convert.go, server/migration_cmd.go, and the corresponding tests.
  • Improving code clarity in pkg/adapter/convert.go by renaming the import alias for github.com/evstack/ev-node/types from rlktypes to evtypes.

The changes look correct and the test adjustments are appropriate. I have no further comments. Good work!

@julienrbrt
Copy link
Member Author

Merging because it is failing because of tastora.

@julienrbrt julienrbrt merged commit 675c673 into main Nov 10, 2025
15 of 19 checks passed
@julienrbrt julienrbrt deleted the julien/bump-v9 branch November 10, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants