Conversation
Summary of ChangesHello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's core Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| if err != nil { | ||
| return nil, 0, fmt.Errorf("load state after init: %w", err) | ||
| } | ||
| return nil, 0, fmt.Errorf("load state: %w", err) |
| LastCommitHash: lastCommit.Hash(), | ||
| DataHash: cmbytes.HexBytes(header.DataHash), | ||
| ConsensusHash: cmbytes.HexBytes(header.ConsensusHash), | ||
| ConsensusHash: cmbytes.HexBytes(make(evtypes.Hash, 32)), |
There was a problem hiding this comment.
Code Review
This pull request bumps the ev-node dependency to v1.0.0-beta.9 and adapts the codebase to the corresponding API changes. The changes are consistent and well-executed.
Key changes include:
- Updating the
ev-nodeversion inDockerfile,go.mod, andtests/integration/go.mod. - Removing the lazy initialization logic for sync nodes in
pkg/adapter/adapter.go, which simplifies theExecuteTxsfunction. This is a welcome simplification, presumably enabled by the updated dependency. - Adapting to the removal of
ConsensusHash,LastResultsHash, andLastCommitHashfields fromev-nodetypes. This is reflected inpkg/adapter/convert.go,server/migration_cmd.go, and the corresponding tests. - Improving code clarity in
pkg/adapter/convert.goby renaming the import alias forgithub.com/evstack/ev-node/typesfromrlktypestoevtypes.
The changes look correct and the test adjustments are appropriate. I have no further comments. Good work!
b74219d to
d1a8cd4
Compare
|
Merging because it is failing because of tastora. |
Overview
Bump to ev-abci v9.