security: fix RUSTSEC-2025-0047 - upgrade slab from 0.4.10 to 0.4.11#2564
security: fix RUSTSEC-2025-0047 - upgrade slab from 0.4.10 to 0.4.11#2564tac0turtle wants to merge 1 commit intomainfrom
Conversation
This addresses the security vulnerability in slab v0.4.10 where get_disjoint_mut incorrectly checked indices against capacity instead of length, allowing out-of-bounds access to uninitialized memory. - Added slab = 0.4.11 to workspace dependencies - Updated Cargo.lock to use patched version Fixes #2563 Co-authored-by: Marko <tac0turtle@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the project's security posture by addressing a known vulnerability in the slab crate. The core change involves upgrading this dependency to a patched version, which resolves an issue that could lead to out-of-bounds memory access. This update ensures the project utilizes a more secure and stable version of the slab library, safeguarding against potential exploits related to memory handling.
Highlights
- Dependency Upgrade: Upgraded the
slabcrate from version 0.4.10 to 0.4.11 to mitigate a security vulnerability (RUSTSEC-2025-0047) related to incorrect index checking. - Build Configuration: Modified
Cargo.tomlto explicitly includeslab = "0.4.11"as a workspace dependency, ensuring the updated version is used across the project. - Lock File Update: Updated
Cargo.lockto reflect the newslabversion and its corresponding checksum, ensuring reproducible builds with the patched dependency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).
|
There was a problem hiding this comment.
Code Review
This pull request addresses a security vulnerability in the slab crate by upgrading it from version 0.4.10 to 0.4.11. The changes correctly update Cargo.lock and specify the new version in the Cargo.toml workspace dependencies. My review includes a suggestion to use a more idiomatic approach for patching transitive dependencies in Rust by using the [patch] section, which can improve clarity and maintainability.
| tonic = { version = "0.10", features = ["transport"] } | ||
| tonic-build = "0.10" | ||
| walkdir = "2.5.0" | ||
| slab = "0.4.11" |
There was a problem hiding this comment.
While adding slab to [workspace.dependencies] works for updating the transitive dependency, a more idiomatic approach in Rust for overriding dependency versions, especially for security patches, is to use the [patch] table in your root Cargo.toml. This makes the intent of overriding a specific version clearer and avoids adding transitive-only dependencies to your [workspace.dependencies] section.
Consider removing this line and adding the following to your Cargo.toml instead:
[patch.crates-io]
slab = "0.4.11"After this change, you may need to run cargo update to ensure Cargo.lock reflects the patch correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2564 +/- ##
=======================================
Coverage 72.38% 72.38%
=======================================
Files 71 71
Lines 7211 7211
=======================================
Hits 5220 5220
Misses 1570 1570
Partials 421 421
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
This addresses the security vulnerability in slab v0.4.10 where get_disjoint_mut incorrectly checked indices against capacity instead of length, allowing out-of-bounds access to uninitialized memory.
Fixes #2563
Generated with Claude Code