Allow for creation of environmental variables for self-hosting/and instance on a different domain/google cloud project#206
Open
samschooler wants to merge 1 commit intoexcalidraw:mainfrom
Conversation
…igins in index.ts; update README.md with new environment variable documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the allowedOrigins are hard-coded. This PR adds the ability to customize this and a few other options via env vars.
This was prompted because the re-write removed the ability for a self hosted instance of excalidraw to export links.
Fix in previous version here: excalidraw/excalidraw#600
Relevant code in new version:
excalidraw-store/index.ts
Lines 28 to 52 in f9270d9
My ideal would be to re-open cors so self-hosted versions can export using the excalidraw.com services.
My second best solution is this PR, coupled with a default removal of the hosted service env vars to avoid confusion.