👌 IMPROVE: Support colon fenced directives #36
+185
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Branch updated. I don't know how to progress from there. Could we get feedback or review? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of fix for #13.
I don't really know what I am doing here. So please, anyone familiar with the mdformat / mdit code base improve! In particular, the list of supported directives is currently hardcoded which is ugly.
I have first tried to build on top of
mdit_py_plugins.colon_fenceinstead ofmdit_py_plugins.container. This would have avoided to handle metadata manually and removed the need to provide a fixed list of directives; however, the content of the directive is not parsed recursively withcolon_fence.Current limitation: yaml metadata delimited by
---is not supported.