Build: use prebuilt alpine version of nim for test-runner#117
Draft
Build: use prebuilt alpine version of nim for test-runner#117
Conversation
This uses `nimlang/nim:1.6.0-alpine-regular` to copy over the alpine version of nim for the test-runner because it is already built and doesn't have to be rebuilt on every CI test.
Member
I wouldn't say there are huge advantages, but there are at least these benefits:
I'd suggest that we use |
Contributor
Author
|
So I'm going to close this PR, but we can revisit it at a future date, perhaps when @ErikSchierboom is back in the virtual office |
Member
|
Let's discuss this once I'm back (next week). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses
nimlang/nim:1.6.0-alpine-regularto copy over the alpineversion of nim for the test-runner because it is already built and
doesn't have to be rebuilt on every CI test.
There are currently issues with this and I'll hopefully figure them out soon
Related to #116. The advantage of this route, is we don't have to maintain our nim base image (@ee7 is there any advantage to maintaining our own? It didn't seem like you are doing anything special in
bin/install_nim.sh)