Update resistor-color.test.ts #1598
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed assertion for the colors data structure and implemented tests for remaining colors
COLORS type should not be asserted if not explicitly typed in the template or mentioned in the docs
By asserting the structure of the data type this prevents correct solutions from passing the test and restricts developer freedom.
Asserting that colors is an string array makes the following data structure trigger a failure even if the colorCode method produces the correct result;
Asserting that COLORS is an array with strings in the exact order and skipping subsequent tests is a lazy way to identify a correct solution.
This solution encourages developer autonomy and implements more robust testing of the solution.