Switch dependency back from typer-slim to typer#13922
Open
svlandeg wants to merge 2 commits intoexplosion:masterfrom
Open
Switch dependency back from typer-slim to typer#13922svlandeg wants to merge 2 commits intoexplosion:masterfrom
typer-slim to typer#13922svlandeg wants to merge 2 commits intoexplosion:masterfrom
Conversation
3 tasks
3 tasks
Member
|
Hey sorry for missing this before! I do prefer the non-rich output, and I haven't been doing much LLM-powered spaCy stuff but I think the less verbose output is probably better there too. |
Contributor
Author
|
Hey Matt! Gotcha, but if you keep things as is you will in fact pull in Rich-formatted output. From |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, long time no see! 😀
Here with my Typer-maintainer-hat on.
Description
Recently, spaCy switched from using
typertotyper-slim. We used to offertyper-slimas a more light-weight package, which didn't depend onrichandshellingham. Unfortuntately, the way it was set up meant that we ran into issues with package managers (e.g. fastapi/typer#1503). We ran a user survey and eventually decided to drop support fortyper-slimaltogether (since 0.22.0). Going forward, it's better to just usetyperas dependency.What this means for this repo:
shellinghamandrichwill be added as indirect requirement, adding about 12MB extra.richpresent in the environment, any Typer app will automatically setrich_markup_modeto"rich"by default (it wasNonewhen Rich wasn't installed). This can be overwritten when creating aTyper()app by settingrich_markup_modetoNone. Alternatively, since Typer 0.22.0 there is a new env varTYPER_USE_RICHthat you can set toFalseto disable Rich entirely everywhere and always. I've gone ahead and went for the first option by settingrich_markup_mode=Nonein the mainapp. Personally, I do like the Rich formatting better, so you can pick which you like most as spaCy has had different behaviour in the past anyway (before PR Switch to typer-slim #13759 it would be formatted with Rich).I'll submit a PR to
weaselas well.Let me know if there's any concerns/questions!
Types of change
External dependency change
Checklist